Messages in this thread | | | Date | Tue, 9 Aug 2022 09:40:47 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register |
| |
On Mon, Aug 08, 2022 at 09:36:13PM +0000, Kani, Toshi wrote: > Platforms with ACPI GHES support should use ghes_edac. This is the > case on Arm. The x86 side has additional platform ID check to protect > from legacy buggy GHES FW existed before ghes_edac enablement.
Sounds to me like we should put all that logic in ghes.c and out of ghes_edac and the EDAC drivers will query it by doing upon load:
<edac_driver>_init:
if (ghes_edac_driver_is_preferred()) return -ENODEV;
And then ghes_edac can become a normal driver module again.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |