Messages in this thread | | | Date | Tue, 9 Aug 2022 08:20:48 +0100 | From | Jean-Philippe Brucker <> | Subject | Re: [PATCH v1 1/1] iommu/virtio: Do not dereference fwnode in struct device |
| |
On Mon, Aug 01, 2022 at 07:51:42PM +0300, Andy Shevchenko wrote: > In order to make the underneath API easier to change in the future, > prevent users from dereferencing fwnode from struct device. > Instead, use the specific device_match_fwnode() API for that. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> --- > drivers/iommu/virtio-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c > index 08eeafc9529f..9fe723f55213 100644 > --- a/drivers/iommu/virtio-iommu.c > +++ b/drivers/iommu/virtio-iommu.c > @@ -925,7 +925,7 @@ static struct virtio_driver virtio_iommu_drv; > > static int viommu_match_node(struct device *dev, const void *data) > { > - return dev->parent->fwnode == data; > + return device_match_fwnode(dev->parent, data); > } > > static struct viommu_dev *viommu_get_by_fwnode(struct fwnode_handle *fwnode) > -- > 2.35.1 >
| |