Messages in this thread | | | Subject | Re: [RESEND RFC 18/18] drm/display/dp_mst: Move all payload info into the atomic state | From | Lyude Paul <> | Date | Mon, 08 Aug 2022 18:53:13 -0400 |
| |
On Mon, 2022-08-08 at 10:02 +0000, Lin, Wayne wrote: > [Public] > > > > > -----Original Message----- > > From: Lyude Paul <lyude@redhat.com> > > Sent: Thursday, August 4, 2022 4:28 AM > > To: Lin, Wayne <Wayne.Lin@amd.com>; dri-devel@lists.freedesktop.org; > > nouveau@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>; Zuo, Jerry > > <Jerry.Zuo@amd.com>; Jani Nikula <jani.nikula@intel.com>; Imre Deak > > <imre.deak@intel.com>; Daniel Vetter <daniel.vetter@ffwll.ch>; Sean Paul > > <sean@poorly.run>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun > > peng (Leo) <Sunpeng.Li@amd.com>; Siqueira, Rodrigo > > <Rodrigo.Siqueira@amd.com>; Deucher, Alexander > > <Alexander.Deucher@amd.com>; Koenig, Christian > > <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David > > Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Jani Nikula > > <jani.nikula@linux.intel.com>; Joonas Lahtinen > > <joonas.lahtinen@linux.intel.com>; Rodrigo Vivi <rodrigo.vivi@intel.com>; > > Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Ben Skeggs > > <bskeggs@redhat.com>; Karol Herbst <kherbst@redhat.com>; Kazlauskas, > > Nicholas <Nicholas.Kazlauskas@amd.com>; Li, Roman > > <Roman.Li@amd.com>; Shih, Jude <Jude.Shih@amd.com>; Simon Ser > > <contact@emersion.fr>; Lakha, Bhawanpreet > > <Bhawanpreet.Lakha@amd.com>; Mikita Lipski <mikita.lipski@amd.com>; > > Claudio Suarez <cssk@net-c.es>; Chen, Ian <Ian.Chen@amd.com>; Colin Ian > > King <colin.king@intel.com>; Wu, Hersen <hersenxs.wu@amd.com>; Liu, > > Wenjing <Wenjing.Liu@amd.com>; Lei, Jun <Jun.Lei@amd.com>; Strauss, > > Michael <Michael.Strauss@amd.com>; Ma, Leo <Hanghong.Ma@amd.com>; > > Thomas Zimmermann <tzimmermann@suse.de>; José Roberto de Souza > > <jose.souza@intel.com>; He Ying <heying24@huawei.com>; Anshuman > > Gupta <anshuman.gupta@intel.com>; Andi Shyti > > <andi.shyti@linux.intel.com>; Ashutosh Dixit <ashutosh.dixit@intel.com>; > > Juston Li <juston.li@intel.com>; Sean Paul <seanpaul@chromium.org>; > > Fernando Ramos <greenfoo@u92.eu>; Luo Jiaxing > > <luojiaxing@huawei.com>; Javier Martinez Canillas <javierm@redhat.com>; > > open list <linux-kernel@vger.kernel.org>; open list:INTEL DRM DRIVERS > > <intel-gfx@lists.freedesktop.org> > > Subject: Re: [RESEND RFC 18/18] drm/display/dp_mst: Move all payload info > > into the atomic state > > > > On Tue, 2022-07-05 at 09:10 +0000, Lin, Wayne wrote: > > > > +struct drm_dp_mst_port; > > > > + > > > > /* DP MST stream allocation (payload bandwidth number) */ > > > > struct dc_dp_mst_stream_allocation { > > > > uint8_t vcp_id; > > > > /* number of slots required for the DP stream in > > > > * transport packet */ > > > > uint8_t slot_count; > > > > + /* The MST port this is on, this is used to associate DC MST > > > > + payloads > > > > with their > > > > + * respective DRM payloads allocations, and can be ignored on non- > > > > Linux. > > > > + */ > > > > > > Is it necessary for adding this new member? Since this is for setting > > > the DC HW and not relating to drm. > > > > I don't entirely know, honestly. The reasons I did it: > > > > * Mapping things from DRM to DC and from DC to DRM is really confusing for > > outside contributors like myself, so it wasn't even really clear to me if > > there was another way to reconstruct the DRM context from the spots > > where > > we call from DC up to DM (not a typo, see next point). > > * These DC structs for MST are already layer mixing as far as I can tell, > > just not in an immediately obvious way. While this struct itself is for DC, > > there's multiple spots where we pass the DC payload structs down from > > DM to > > DC, then pass them back up from DC to DM and have to figure out how to > > reconstruct the DRM context that we actually need to use the MST helpers > > from that. So, that kind of further complicates the confusion of where > > layers should be separated. > > * As far as I'm aware with C there shouldn't be any issue with adding a > > pointer to a struct whose contents are undefined. IMHO, this is also > > preferable to just using void* because then at least you get some hint as > > to the actual type of the data and avoid the possibility of casting it to > > the wrong type. So tl;dr, on any platform even outside of Linux with a > > reasonably compliant compiler this should still build just fine. It'll even > > give you the added bonus of warning people if they try to access the > > contents of this member in DC on non-Linux platforms. If void* is preferred > > though I'm fine with switching it to that. > > > > -- > > Cheers, Lyude Paul (she/her) Software Engineer at Red Hat > > Hi Lyude, > > Thanks for your time! > I was thinking that our DC just mainly takes care of HW related programming. > Struct dc_dp_mst_stream_allocation is only used to construct a copy of the virtual > channel payload ID and slots count of payload allocation table determined by > dm/drm. ID and slots are only things required for programming HW registers. > I think there shouldn't be any spots to try to construct the DRM context from > this dc struct since there is no such concept in HW level. Our HW should only > take care of local DP link and it doesn't have overall topology info.
Looking at the code I wrote again and realizing I slightly misspoke, looking at the code again I think I probably can drop this. It's likely I just got totally lost with the DC codebase and thought this was necessary when it wasn't. Will drop in the respin
> > Thanks! > > Regards, > Wayne
-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
| |