Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 8 Aug 2022 20:39:06 +0200 | Subject | Re: [PATCH v1 5/5] regmap: mmio: Introduce IO accessors that can talk to IO port |
| |
On Mon, Aug 8, 2022 at 6:05 PM Mark Brown <broonie@kernel.org> wrote: > On Mon, Aug 08, 2022 at 04:40:26PM +0200, Andy Shevchenko wrote: > > On Mon, Aug 8, 2022 at 3:31 PM Mark Brown <broonie@kernel.org> wrote: > > > On Fri, Aug 05, 2022 at 11:53:21PM +0300, Andy Shevchenko wrote:
...
> > > > That said, reimplement current Big Endian MMIO accessors by replacing > > > > ioread()/iowrite() with respective read()/write() and swab() calls. > > > > While at it, add IO port support with a corresponding flag added. > > > > This should be a separate patch. > > > OK! Then we remove some code and (re-)add it later. Do we need this churn? > > Another way is to add IO port accessors and then fix the MMIO. > > Add and then fix seems sensible,
Got it, thanks!
-- With Best Regards, Andy Shevchenko
| |