lkml.org 
[lkml]   [2022]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 29/30] mfd: tc6393xb: Remove #ifdef guards for PM related functions
    Date
    Use the new pm_sleep_ptr() macro to handle the .suspend/.resume
    callbacks.

    This macro allow the suspend and resume functions to be automatically
    dropped by the compiler when CONFIG_SUSPEND is disabled, without having
    to use #ifdef guards.

    This has the advantage of always compiling these functions in,
    independently of any Kconfig option. Thanks to that, bugs and other
    regressions are subsequently easier to catch.

    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    ---
    drivers/mfd/tc6393xb.c | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
    index aa903a31dd43..997bb8b5881d 100644
    --- a/drivers/mfd/tc6393xb.c
    +++ b/drivers/mfd/tc6393xb.c
    @@ -813,7 +813,6 @@ static int tc6393xb_remove(struct platform_device *dev)
    return 0;
    }

    -#ifdef CONFIG_PM
    static int tc6393xb_suspend(struct platform_device *dev, pm_message_t state)
    {
    struct tc6393xb_platform_data *tcpd = dev_get_platdata(&dev->dev);
    @@ -876,16 +875,12 @@ static int tc6393xb_resume(struct platform_device *dev)

    return 0;
    }
    -#else
    -#define tc6393xb_suspend NULL
    -#define tc6393xb_resume NULL
    -#endif

    static struct platform_driver tc6393xb_driver = {
    .probe = tc6393xb_probe,
    .remove = tc6393xb_remove,
    - .suspend = tc6393xb_suspend,
    - .resume = tc6393xb_resume,
    + .suspend = pm_sleep_ptr(tc6393xb_suspend),
    + .resume = pm_sleep_ptr(tc6393xb_resume),

    .driver = {
    .name = "tc6393xb",
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-08-08 19:47    [W:4.165 / U:0.556 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site