Messages in this thread | | | From | Rob Herring <> | Date | Mon, 8 Aug 2022 09:55:54 -0600 | Subject | Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name |
| |
On Sat, Aug 6, 2022 at 10:34 AM Markuss Broks <markuss.broks@gmail.com> wrote: > > The "node" argument is actually an offset,
It's an offset to a node in the FDT. The fact that it is an offset is an internal implementation detail of the FDT format. So really, it's a handle to a node. 'node' is more descriptive to its purpose.
> and it's also an "int", and not "unsigned long".
Uh, no it's not. of_flat_dt_*() functions all take an unsigned long.
Rob
| |