Messages in this thread | | | Date | Mon, 8 Aug 2022 09:26:57 +0300 | Subject | Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible | From | Krzysztof Kozlowski <> |
| |
On 07/08/2022 09:51, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your review. > > On Fri, 5 Aug 2022 at 09:36, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 04/08/2022 20:18, Tomer Maimon wrote: >>> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible >>> string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules. >>> >>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >> >> Your previous commit adding that compatible was simply wrong and not >> matching the driver and it is not the first time. I think all Nuvoton >> patches need much more careful review :( > Will do and sorry about all the mess... >> >> You forgot the fixes tag: >> >> Fixes: 84261749e58a ("dt-bindings: ipmi: Add npcm845 compatible") > Will add the tag next version.
You received a bit different review from Corey, so to be clear: 1. Your approach is correct, assuming the devices are really compatible. 2. Add a fixes tag and send a v3, to get my ack.
Best regards, Krzysztof
| |