lkml.org 
[lkml]   [2022]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: sa1100: make variable sa1100dog_driver static
On Tue, Aug 02, 2022 at 10:08:19AM +0800, sunliming wrote:
> This symbol is not used outside of sa1100_wdt.c, so marks it static.
>
> Fixes the following warning:
>
> >> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/sa1100_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
> index 2d0a06a158a8..82ac5d19f519 100644
> --- a/drivers/watchdog/sa1100_wdt.c
> +++ b/drivers/watchdog/sa1100_wdt.c
> @@ -238,7 +238,7 @@ static int sa1100dog_remove(struct platform_device *pdev)
> return 0;
> }
>
> -struct platform_driver sa1100dog_driver = {
> +static struct platform_driver sa1100dog_driver = {
> .driver.name = "sa1100_wdt",
> .probe = sa1100dog_probe,
> .remove = sa1100dog_remove,
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2022-08-08 15:31    [W:0.055 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site