Messages in this thread | | | Date | Mon, 8 Aug 2022 14:02:49 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v1 2/5] regmap: mmio: Drop unneeded and duplicative checks around CLK calls |
| |
On Fri, Aug 05, 2022 at 11:53:18PM +0300, Andy Shevchenko wrote:
> The commit 6b8e090ecc3d ("regmap: use IS_ERR() to check clk_get() > results") assumes that CLK calls return the error pointer when clock > is not found. However in the current code the described situation > is simply impossible, because the regmap won't be created with > missed clock if requested. The only way when it can be the case is > what the above mentioned commit introduced by itself, when clock is > not provided.
> Taking above into consideration, effectively revert the commit > 6b8e090ecc3d and while at it, drop unneeded NULL checks since CLK > calls are NULL-aware.
I don't understand the supposed benefit of this. Yes, the clk API does currently accept NULL as a valid clock and returns it as a dummy but explicitly taking advantage of that in the way that this does just feels more sloppy than the current behaviour. [unhandled content-type:application/pgp-signature] | |