lkml.org 
[lkml]   [2022]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/16] objtool: Fix SEGFAULT
    Date
    From: Christophe Leroy <christophe.leroy@csgroup.eu>

    find_insn() will return NULL in case of failure. Check insn in order
    to avoid a kernel Oops for NULL pointer dereference.

    Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    ---
    tools/objtool/check.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/objtool/check.c b/tools/objtool/check.c
    index 0cec74da7ffe..0ef805843d4f 100644
    --- a/tools/objtool/check.c
    +++ b/tools/objtool/check.c
    @@ -205,7 +205,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
    return false;

    insn = find_insn(file, func->sec, func->offset);
    - if (!insn->func)
    + if (!insn || !insn->func)
    return false;

    func_for_each_insn(file, func, insn) {
    --
    2.31.1
    \
     
     \ /
      Last update: 2022-08-08 13:51    [W:4.199 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site