lkml.org 
[lkml]   [2022]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map
    On Sun 07 Aug 05:26 PDT 2022, Molly Sophia wrote:

    > Currently in the wakeirq_map, gpio36 and gpio37 have the same wakeirq
    > number, resulting in gpio37 being unable to trigger interrupts.
    > It looks like that this is a typo in the wakeirq map. So fix it.
    >

    Thank you for finding this, I've been scratching my head about the
    i2c-hid interrupts on this gpio for a while now. This indeed looks like
    a typo, and the documentation confirms that 44 is the correct PDC irq
    line.

    > Signed-off-by: Molly Sophia <mollysophia379@gmail.com>

    Fixes: 97423113ec4b ("pinctrl: qcom: Add sc8180x TLMM driver")
    Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

    Regards,
    Bjorn

    > ---
    > drivers/pinctrl/qcom/pinctrl-sc8180x.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
    > index 6bec7f143134..b4bf009fe23e 100644
    > --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
    > +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
    > @@ -1582,7 +1582,7 @@ static const int sc8180x_acpi_reserved_gpios[] = {
    > static const struct msm_gpio_wakeirq_map sc8180x_pdc_map[] = {
    > { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, { 12, 104 },
    > { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, { 30, 39 }, { 36, 43 },
    > - { 37, 43 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
    > + { 37, 44 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
    > { 42, 48 }, { 46, 50 }, { 47, 49 }, { 48, 51 }, { 49, 53 }, { 50, 52 },
    > { 51, 116 }, { 51, 123 }, { 53, 54 }, { 54, 55 }, { 55, 56 },
    > { 56, 57 }, { 58, 58 }, { 60, 60 }, { 68, 62 }, { 70, 63 }, { 76, 86 },
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2022-08-08 06:18    [W:3.786 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site