lkml.org 
[lkml]   [2022]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for Qualcomm SMBCHG
    From
    On 08/08/2022 10:34, Yassine Oudjana wrote:
    > From: Yassine Oudjana <y.oudjana@protonmail.com>
    >
    > Add DT schema for the switch-mode battery charger found on Qualcomm
    > PMICs such as PMI8994. Due to lack of documentation, some interrupt
    > descriptions might be inaccurate.
    >
    > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
    > ---
    > .../bindings/power/supply/qcom,smbchg.yaml | 205 ++++++++++++++++++
    > MAINTAINERS | 8 +
    > 2 files changed, 213 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
    > new file mode 100644
    > index 000000000000..d825a9c10b3e
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
    > @@ -0,0 +1,205 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/power/supply/qcom,smbchg.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Qualcomm PMIC Switch-Mode Battery Charger
    > +
    > +maintainers:
    > + - Yassine Oudjana <y.oudjana@protonmail.com>
    > + - Alejandro Tafalla <atafalla@dnyon.com>
    > +
    > +properties:
    > + compatible:
    > + enum:
    > + - qcom,pmi8994-smbchg
    > + - qcom,pmi8996-smbchg
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + monitored-battery:
    > + description: |
    > + phandle of battery characteristics node.
    > + The charger uses the following properties:
    > + - charge-term-current-microamp
    > + - constant-charge-current-max-microamp
    > + - voltage-max-design-microvolt
    > + The constant-charge-current-max-microamp and voltage-max-design-microvolt
    > + properties must be set.
    > + See Documentation/devicetree/bindings/power/supply/battery.yaml
    > +
    > + interrupts:
    > + items:
    > + - description: Charger error
    > + - description: Charger inhibited
    > + - description: Charger precharge safety timer timeout
    > + - description: Charger charge safety timer timeout
    > + - description: Charger pre to fast charging switch threshold reached
    > + - description: Charger recharge threshold reached
    > + - description: Charger taper threshold reached
    > + - description: Charger charge termination threshold reached
    > + - description: Battery hot
    > + - description: Battery warm
    > + - description: Battery cold
    > + - description: Battery cool
    > + - description: Battery overvoltage
    > + - description: Battery low
    > + - description: Battery missing
    > + - description: Battery thermistor missing # unconfirmed
    > + - description: USB input undervolt
    > + - description: USB input overvolt
    > + - description: USB input source detected
    > + - description: OTG regulator failure
    > + - description: OTG regulator overcurrent
    > + - description: Automatic input current limiting done
    > + - description: USB ID pin changed
    > + - description: DC input undervolt
    > + - description: DC input overvolt
    > + - description: Power OK
    > + - description: Temperature shutdown
    > + - description: Watchdog timeout
    > + - description: Flash failure
    > + - description: OTST2 # unknown
    > + - description: OTST3 # unknown

    It seems you listed register interrupts, not physical pins. This should
    be interrupt lines.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-08-08 10:43    [W:5.037 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site