Messages in this thread | | | Date | Sun, 7 Aug 2022 10:34:38 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v1 1/3] hwmon: (pwm-fan) Make use of device properties |
| |
Hello,
[dropped Bartlomiej Zolnierkiewicz from Cc:, the address bounced in the past]
at a quick glance this looks nice. I wonder if it makes sense to split the patch. For example the change
- ctx->pwm = devm_of_pwm_get(dev, dev->of_node, NULL); + ctx->pwm = devm_pwm_get(dev, NULL);
could stand alone. Also I think this change is the relevant part in patch #1 that makes patches #2 and #3 possible.
When this patch doesn't get split, the series needs some coordination, as patch #1 is for hwmon and patches #2 and #3 are for pwm.
Splitting the series into:
hwmon: (pwm-fan) Use of devm_pwm_get() instead of devm_of_pwm_get() pwm: core: Get rid of unused devm_of_pwm_get() pwm: core: Make of_pwm_get() static
for pwm and the remainder of this patch for hwmon might make application of the changes here easier to coordinate.
But still: Thanks for your effort and Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |