Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 6 Aug 2022 12:00:45 +0200 | Subject | Re: [PATCH 4/5] asus-wmi: Document many of the undocumented API |
| |
On Fri, Aug 5, 2022 at 10:21 AM Luke D. Jones <luke@ljones.dev> wrote: >
Missed commit message.
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
...
> +Date: Dec 2022
I would be more optimistic here...
> +KernelVersion: 5.17
...and definitely this is the wrong version. I would suggest 6.0.
Both comments are applicable for other similar cases.
In case you are documenting new and old APIs, split this to two patches with different dates and kernel versions. And commit messages should be different. -- With Best Regards, Andy Shevchenko
| |