Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v1 2/4] pwm: sysfs: Return directly from the for-loop in PM callbacks | Date | Sun, 7 Aug 2022 00:23:29 +0300 |
| |
There is no need to assign ret to 0 and then break the loop just for returning the error to the caller. Instead, return directly from the for-loop, and 0 otherwise.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pwm/sysfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c index c21b6046067b..1543fe07765b 100644 --- a/drivers/pwm/sysfs.c +++ b/drivers/pwm/sysfs.c @@ -413,7 +413,7 @@ static int pwm_class_resume_npwm(struct device *parent, unsigned int npwm) { struct pwm_chip *chip = dev_get_drvdata(parent); unsigned int i; - int ret = 0; + int ret; for (i = 0; i < npwm; i++) { struct pwm_device *pwm = &chip->pwms[i]; @@ -427,17 +427,17 @@ static int pwm_class_resume_npwm(struct device *parent, unsigned int npwm) state.enabled = export->suspend.enabled; ret = pwm_class_apply_state(export, pwm, &state); if (ret < 0) - break; + return ret; } - return ret; + return 0; } static int pwm_class_suspend(struct device *parent) { struct pwm_chip *chip = dev_get_drvdata(parent); unsigned int i; - int ret = 0; + int ret; for (i = 0; i < chip->npwm; i++) { struct pwm_device *pwm = &chip->pwms[i]; @@ -457,11 +457,11 @@ static int pwm_class_suspend(struct device *parent) * this suspend function. */ pwm_class_resume_npwm(parent, i); - break; + return ret; } } - return ret; + return 0; } static int pwm_class_resume(struct device *parent) -- 2.35.1
| |