lkml.org 
[lkml]   [2022]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/5] asus-wmi: Add support for RGB keyboards
On Sat, Aug 6, 2022 at 12:49 PM Luke Jones <luke@ljones.dev> wrote:

Please, do not top-post! It's not appreciated in the OSS community(ies).

> I do agree. It's what I meant by prepped. I think I've addressed
> everything you've raised, so I'll leave it to bake a few days with my
> testing then submit new version on Tuesday (Hans please wait for v2).

We are now at the merge window, it means you have enough time to take
review comments and address them carefully, no need to rush. Your
series at the best can be in v6.0, which is 2 months ahead, which
means we have somewhat 6-7 weeks for you to clean up and make the
series better.

> Many thanks for your time taken to review this. I'm not an expert at C
> or the kernel by any stretch so reviews are critical for me. Also thank
> you for the link on git messages - I'll go through each patch and
> ensure they're better.

You are welcome!

> On Sat, Aug 6 2022 at 12:02:19 +0200, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sat, Aug 6, 2022 at 11:33 AM Luke Jones <luke@ljones.dev> wrote:
> >> On Sat, Aug 6 2022 at 11:10:37 +0200, Andy Shevchenko
> >> <andy.shevchenko@gmail.com> wrote:

...

> >> I do have another version already prepped
> >
> > Hold on and try to address many more review comments. It seems the
> > series needs much more work, otherwise it will be spam in the mailing
> > list and demotivating reviewers to continue.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-08-06 13:18    [W:0.109 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site