lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V7 1/4] MIPS&LoongArch&NIOS2: Adjust prototypes of p?d_init()
Hi Huacai,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on soc/for-next]
[also build test WARNING on kvm/queue arm64/for-next/core linus/master v5.19 next-20220805]
[cannot apply to akpm-mm/mm-everything tip/x86/mm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/mm-sparse-vmemmap-Generalise-helpers-and-enable-for-LoongArch/20220802-180930
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: mips-buildonly-randconfig-r001-20220805 (https://download.01.org/0day-ci/archive/20220806/202208061111.tJqmWcij-lkp@intel.com/config)
compiler: mips64el-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/284d2afe87bf580321065fb587ffb8ed5a1d0874
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Huacai-Chen/mm-sparse-vmemmap-Generalise-helpers-and-enable-for-LoongArch/20220802-180930
git checkout 284d2afe87bf580321065fb587ffb8ed5a1d0874
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/mm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from arch/mips/mm/init.c:42:
arch/mips/include/asm/pgalloc.h: In function 'pud_alloc_one':
>> arch/mips/include/asm/pgalloc.h:96:26: warning: passing argument 1 of 'pud_init' makes pointer from integer without a cast [-Wint-conversion]
96 | pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
| ^~~~~~~~~~~~~~~~~~
| |
| long unsigned int
In file included from arch/mips/include/asm/pgtable.h:17,
from include/linux/pgtable.h:6,
from include/linux/mm.h:29,
from include/linux/pagemap.h:8,
from arch/mips/mm/init.c:21:
arch/mips/include/asm/pgtable-64.h:329:28: note: expected 'void *' but argument is of type 'long unsigned int'
329 | extern void pud_init(void *addr);
| ~~~~~~^~~~
arch/mips/include/asm/pgalloc.h:96:17: error: too many arguments to function 'pud_init'
96 | pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
| ^~~~~~~~
arch/mips/include/asm/pgtable-64.h:329:13: note: declared here
329 | extern void pud_init(void *addr);
| ^~~~~~~~
arch/mips/mm/init.c: At top level:
arch/mips/mm/init.c:60:6: warning: no previous prototype for 'setup_zero_pages' [-Wmissing-prototypes]
60 | void setup_zero_pages(void)
| ^~~~~~~~~~~~~~~~
--
In file included from arch/mips/mm/pgtable.c:9:
arch/mips/include/asm/pgalloc.h: In function 'pud_alloc_one':
>> arch/mips/include/asm/pgalloc.h:96:26: warning: passing argument 1 of 'pud_init' makes pointer from integer without a cast [-Wint-conversion]
96 | pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
| ^~~~~~~~~~~~~~~~~~
| |
| long unsigned int
In file included from arch/mips/include/asm/pgtable.h:17,
from include/linux/pgtable.h:6,
from include/linux/mm.h:29,
from arch/mips/mm/pgtable.c:7:
arch/mips/include/asm/pgtable-64.h:329:28: note: expected 'void *' but argument is of type 'long unsigned int'
329 | extern void pud_init(void *addr);
| ~~~~~~^~~~
arch/mips/include/asm/pgalloc.h:96:17: error: too many arguments to function 'pud_init'
96 | pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
| ^~~~~~~~
arch/mips/include/asm/pgtable-64.h:329:13: note: declared here
329 | extern void pud_init(void *addr);
| ^~~~~~~~


vim +/pud_init +96 arch/mips/include/asm/pgalloc.h

3377e227af441a Alex Belits 2017-02-16 89
3377e227af441a Alex Belits 2017-02-16 90 static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
3377e227af441a Alex Belits 2017-02-16 91 {
3377e227af441a Alex Belits 2017-02-16 92 pud_t *pud;
3377e227af441a Alex Belits 2017-02-16 93
473738eb78c3e3 Michal Hocko 2017-07-12 94 pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_ORDER);
3377e227af441a Alex Belits 2017-02-16 95 if (pud)
3377e227af441a Alex Belits 2017-02-16 @96 pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
3377e227af441a Alex Belits 2017-02-16 97 return pud;
3377e227af441a Alex Belits 2017-02-16 98 }
3377e227af441a Alex Belits 2017-02-16 99

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-08-06 05:42    [W:0.058 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site