lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 27/33] drm-print: add drm_dbg_driver to improve namespace symmetry
    Date
    drm_print defines all of these:
    drm_dbg_{core,kms,prime,atomic,vbl,lease,_dp,_drmres}

    but not drm_dbg_driver itself, since it was the original drm_dbg.

    To improve namespace symmetry, change the drm_dbg defn to
    drm_dbg_driver, and redef grandfathered name to symmetric one.

    This will help with nouveau, which uses its own stack of macros to
    construct calls to dev_info, dev_dbg, etc, for which adaptation means
    drm_dbg_##driver constructs.

    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    include/drm/drm_print.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
    index f8bb3e7158c6..dfdd81c3287c 100644
    --- a/include/drm/drm_print.h
    +++ b/include/drm/drm_print.h
    @@ -468,7 +468,7 @@ void __drm_dev_dbg(const struct device *dev, enum drm_debug_category category,

    #define drm_dbg_core(drm, fmt, ...) \
    drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
    -#define drm_dbg(drm, fmt, ...) \
    +#define drm_dbg_driver(drm, fmt, ...) \
    drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_DRIVER, fmt, ##__VA_ARGS__)
    #define drm_dbg_kms(drm, fmt, ...) \
    drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__)
    @@ -487,6 +487,7 @@ void __drm_dev_dbg(const struct device *dev, enum drm_debug_category category,
    #define drm_dbg_drmres(drm, fmt, ...) \
    drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_DRMRES, fmt, ##__VA_ARGS__)

    +#define drm_dbg(drm, fmt, ...) drm_dbg_driver(drm, fmt, ##__VA_ARGS__)

    /*
    * printk based logging
    --
    2.37.1
    \
     
     \ /
      Last update: 2022-08-05 23:58    [W:2.472 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site