Messages in this thread | | | Date | Fri, 5 Aug 2022 09:10:45 +0200 | Subject | Re: [PATCH] dt-bindings: iio: gyroscope: bosch,bmg160: correct number of pins | From | Krzysztof Kozlowski <> |
| |
On 31/07/2022 14:30, Jonathan Cameron wrote: > On Wed, 27 Jul 2022 16:01:48 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> BMG160 has two interrupt pins to which interrupts can be freely mapped. >> Correct the schema to express such case and fix warnings like: >> >> qcom/msm8916-alcatel-idol347.dtb: gyroscope@68: interrupts: [[97, 1], [98, 1]] is too long >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > We may need more than this. What if only INT2 is wired?
Right, thanks for pointing it out.
> I'd expect such > a device's binding to include interrupt-names to cover that case. > We'd also need a bunch of driver code to route the resulting interrupts.
Yes, which is a bit out of scope of fixing schema/DTS. The driver supports only one interrupt and bindings are unspecific, so I think the author just did not care about making it correct.
> > I think the snag is that adding such support will break existing bindings using the > below.
I can prepare more relaxed version of the patch.
Best regards, Krzysztof
| |