lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v3 net 0/4] Do not use RT_TOS for IPv6 flowlabel
Date
According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

---
v1 -> v2:
- Fix spacing of "Fixes" tag.
- Add missing CCs
v2 -> v3:
- Add the info from the cover to the actual patch message (Guillaume Nault)

Matthias May (4):
geneve: do not use RT_TOS for IPv6 flowlabel
vxlan: do not use RT_TOS for IPv6 flowlabel
mlx5: do not use RT_TOS for IPv6 flowlabel
ipv6: do not use RT_TOS for IPv6 flowlabel

drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++--
drivers/net/geneve.c | 3 +--
drivers/net/vxlan/vxlan_core.c | 2 +-
net/ipv6/ip6_output.c | 3 +--
4 files changed, 5 insertions(+), 7 deletions(-)

--
2.35.1

\
 
 \ /
  Last update: 2022-08-05 21:25    [W:0.096 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site