lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi
On Fri, Aug 5, 2022 at 8:07 PM Colin Foster
<colin.foster@in-advantage.com> wrote:
> On Fri, Aug 05, 2022 at 07:58:06PM +0200, Andy Shevchenko wrote:
> > On Fri, Aug 5, 2022 at 7:44 PM Colin Foster
> > <colin.foster@in-advantage.com> wrote:
> > > On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote:

...

> > > > +int ocelot_chip_reset(struct device *dev)
> > >
> > > #include <linux/device.h>
> >
> > Nope,
> >
> > struct device;

...

> > > > +static int ocelot_spi_initialize(struct device *dev)
> > >
> > > #include <linux/device.h>
> >
> > Ditto.
>
> ocelot-spi.c uses devm_kzalloc, so that should still be included.
>
> ocelot-core.c uses dev_get_drvdata.
>
> So I think I still want the includes... but for different reasons.

Yes in this case.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-08-05 20:15    [W:0.054 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site