Messages in this thread | | | Date | Fri, 5 Aug 2022 22:53:51 +0800 | From | kernel test robot <> | Subject | Re: [PATCH] net: atlantic: fix aq_vec index out of range error |
| |
Hi AceLan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] [also build test WARNING on net/master linus/master horms-ipvs/master v5.19 next-20220804] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/AceLan-Kao/net-atlantic-fix-aq_vec-index-out-of-range-error/20220805-173434 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f86d1fbbe7858884d6754534a0afbb74fc30bc26 config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220805/202208052211.yWBUaHIc-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/23a65a8ebdb1e74cf7fc03a89741246de646622b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review AceLan-Kao/net-atlantic-fix-aq_vec-index-out-of-range-error/20220805-173434 git checkout 23a65a8ebdb1e74cf7fc03a89741246de646622b # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/aquantia/atlantic/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/aquantia/atlantic/aq_nic.c: In function 'aq_nic_polling_timer_cb': >> drivers/net/ethernet/aquantia/atlantic/aq_nic.c:268:26: warning: variable 'aq_vec' set but not used [-Wunused-but-set-variable] 268 | struct aq_vec_s *aq_vec = NULL; | ^~~~~~ drivers/net/ethernet/aquantia/atlantic/aq_nic.c: In function 'aq_nic_stop': drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1384:26: warning: variable 'aq_vec' set but not used [-Wunused-but-set-variable] 1384 | struct aq_vec_s *aq_vec = NULL; | ^~~~~~
vim +/aq_vec +268 drivers/net/ethernet/aquantia/atlantic/aq_nic.c
97bde5c4f909a55a David VomLehn 2017-01-23 264 e99e88a9d2b06746 Kees Cook 2017-10-16 265 static void aq_nic_polling_timer_cb(struct timer_list *t) 97bde5c4f909a55a David VomLehn 2017-01-23 266 { e99e88a9d2b06746 Kees Cook 2017-10-16 267 struct aq_nic_s *self = from_timer(self, t, polling_timer); 97bde5c4f909a55a David VomLehn 2017-01-23 @268 struct aq_vec_s *aq_vec = NULL; 97bde5c4f909a55a David VomLehn 2017-01-23 269 unsigned int i = 0U; 97bde5c4f909a55a David VomLehn 2017-01-23 270 97bde5c4f909a55a David VomLehn 2017-01-23 271 for (i = 0U, aq_vec = self->aq_vec[0]; 23a65a8ebdb1e74c Chia-Lin Kao (AceLan 2022-08-05 272) self->aq_vecs > i; ++i) 23a65a8ebdb1e74c Chia-Lin Kao (AceLan 2022-08-05 273) aq_vec_isr(i, (void *)self->aq_vec[i]); 97bde5c4f909a55a David VomLehn 2017-01-23 274 97bde5c4f909a55a David VomLehn 2017-01-23 275 mod_timer(&self->polling_timer, jiffies + 97bde5c4f909a55a David VomLehn 2017-01-23 276 AQ_CFG_POLLING_TIMER_INTERVAL); 97bde5c4f909a55a David VomLehn 2017-01-23 277 } 97bde5c4f909a55a David VomLehn 2017-01-23 278
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |