Messages in this thread | | | From | Shenwei Wang <> | Subject | RE: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver | Date | Fri, 5 Aug 2022 12:31:09 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, August 5, 2022 1:57 AM > To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver > > Caution: EXT Email > > On 04/08/2022 20:49, Shenwei Wang wrote: > > The SCU firmware on i.MX8 platforms provides a set of APIs to control > > the GPIO PINs on the SCU domain. This patch implements the standard > > GPIO driver interface to access those PINs on the SCU domain over the > > SCU APIs. > > > > Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com> > > --- > > drivers/firmware/imx/Kconfig | 6 ++ > > drivers/firmware/imx/Makefile | 1 + > > drivers/firmware/imx/imx-scu-gpio.c | 139 > > ++++++++++++++++++++++++++++ > > 3 files changed, 146 insertions(+) > > create mode 100644 drivers/firmware/imx/imx-scu-gpio.c > > > > diff --git a/drivers/firmware/imx/Kconfig > > b/drivers/firmware/imx/Kconfig index c027d99f2a59..484c13f3149a 100644 > > --- a/drivers/firmware/imx/Kconfig > > +++ b/drivers/firmware/imx/Kconfig > > @@ -28,3 +28,9 @@ config IMX_SCU_PD > > depends on IMX_SCU > > help > > The System Controller Firmware (SCFW) based power domain driver. > > + > > +config IMX_SCU_GPIO > > + def_bool y > > + depends on IMX_SCU > > + help > > + Say Y here to enable the imx8 gpio over SCFW MISC API > > gpio driver go to drivers/gpio/
I was thinking to put the driver under drivers/gpio at the beginning too. Are there any requirements to put a driver under firmware directory?
Thanks, Shenwei
> > Best regards, > Krzysztof
| |