lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging: r8188eu: make driver metadata macro names more consistent
On Thu, Aug 04, 2022 at 12:29:10AM +0200, Grzegorz Szymaszek wrote:
> Rename DRIVERVERSION to DRV_VERSION so that it looks more alike the
> other macros, DRV_NAME and FW_*, and matches the most popular (as it
> seems from a quick review) conventions in other drivers.
>
> Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
> ---
> drivers/staging/r8188eu/include/drv_types.h | 5 ++---
> drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +-
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/r8188eu/include/drv_types.h
> index f51b83515953..3328c66d1ef1 100644
> --- a/drivers/staging/r8188eu/include/drv_types.h
> +++ b/drivers/staging/r8188eu/include/drv_types.h
> @@ -10,8 +10,6 @@
> #ifndef __DRV_TYPES_H__
> #define __DRV_TYPES_H__
>
> -#define DRV_NAME "r8188eu"

This should just be KBUILD_MODNAME, no need to create yet-another-macro
for this one.

> -
> #include "osdep_service.h"
> #include "wlan_bssdef.h"
> #include "rtw_ht.h"
> @@ -36,7 +34,8 @@
> #include "rtl8188e_hal.h"
> #include "rtw_fw.h"
>
> -#define DRIVERVERSION "v4.1.4_6773.20130222"
> +#define DRV_NAME "r8188eu"

Again, KBUILD_MODNAME

> +#define DRV_VERSION "v4.1.4_6773.20130222"

As the driver is now in the kernel, this "version" string can just go
away. Can you redo this patch to do the DRV_NAME thing first, and then
drop the DRV_VERSION field after that?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-08-05 08:40    [W:0.267 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site