lkml.org 
[lkml]   [2022]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] scsi: initio: remove redundant assignment to pointer scb
    Date
    The variable scb is assigned a value but it is never read. The assignment
    is redundant and can be removed. Also replace the != NULL check with the
    more usual non-null check idiom.

    Cleans up clang scan build warning:
    drivers/scsi/initio.c:1169:9: warning: Although the value stored to 'scb'
    is used in the enclosing expression, the value is never actually read
    from 'scb' [deadcode.DeadStores]

    Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
    ---
    drivers/scsi/initio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
    index f585d6e5fab9..375261d67619 100644
    --- a/drivers/scsi/initio.c
    +++ b/drivers/scsi/initio.c
    @@ -1166,7 +1166,7 @@ static void tulip_scsi(struct initio_host * host)
    return;
    }
    if (host->jsint & (TSS_FUNC_COMP | TSS_BUS_SERV)) { /* func complete or Bus service */
    - if ((scb = host->active) != NULL)
    + if (host->active)
    initio_next_state(host);
    return;
    }
    --
    2.35.3
    \
     
     \ /
      Last update: 2022-08-05 13:41    [W:6.325 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site