Messages in this thread |  | | Date | Fri, 5 Aug 2022 00:23:12 +0200 | From | Grzegorz Szymaszek <> | Subject | Re: [PATCH 1/3] staging: r8188eu: set firmware path in a macro |
| |
On Thu, Aug 04, 2022 at 10:11:58PM +0200, Philipp Hortmann wrote: > On 8/4/22 00:28, Grzegorz Szymaszek wrote: > > diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c > > -%<- > > -MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin"); > > +MODULE_FIRMWARE(FW_RTL8188EU); > > > It failed to apply your patch as the following line: > MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin"); > is not in the repo. Inserted line in my repo to apply patch.
I’m sorry, I didn’t add the base tree reference. Right now, git format-patch generates the following:
base-commit: 9de1f9c8ca5100a02a2e271bdbde36202e251b4b prerequisite-patch-id: 79964bd0bcd260f1df53830a81e009c34993ee6f
The prerequisite patch is available at <https://lore.kernel.org/lkml/YulcdKfhA8dPQ78s@nx64de-df6d00/>.
> Why is the coverletter missing?
I didn’t think it would be necessary, since the patches are quite simple and there are just three of them. Again, I’m sorry, I don’t want to make it harder for anyone to review my patches. Hopefully I will learn more of the kernel development practises without wasting too much time of patch reviewers.
Should I send an improved (with the base tree reference and with a short cover letter) patch series?
> Tested all three patches.
Thanks! [unhandled content-type:application/pgp-signature] |  |