Messages in this thread | | | Date | Thu, 04 Aug 2022 21:53:39 +0000 | From | Barnabás Pőcze <> | Subject | Re: [PATCH v2 1/1] asus-wmi: Add support for TUF laptop keyboard states |
| |
Hi Hans
2022. augusztus 4., csütörtök 15:22 keltezéssel, Hans de Goede <hdegoede@redhat.com> írta:
> [...] > Please make this an extra attribute for the led_class_device, > you can do this by adding this attribute to a separate > attribute_group, lets say e.g. "tuf_rgb_attributes" and then > in the "[PATCH] asus-wmi: Add support for TUF laptop keyboard RGB" > code add: > > mc_cdev->led_cdev.groups = tuf_rgb_attributes; > > and then the "tuf_krgb_state" file should show up as: > /sys/class/leds/asus::multicolour/tuf_krgb_state
I am not sure this will work because `led_classdev_multicolor_register_ext()` overrides the embedded LED device's `led_classdev::groups` with `led_multicolor_groups` to provide the multi-color functionality before calling `led_classdev_register_ext()`.
> [...]
Regards, Barnabás Pőcze
| |