Messages in this thread | | | Date | Thu, 4 Aug 2022 12:03:56 -0700 | Subject | Re: [PATCH] x86/acrn: Improve ACRN hypercalls | From | Dave Hansen <> |
| |
On 8/4/22 11:56, Uros Bizjak wrote: > The %r8 is not preserved across function calls, so your statement > above is correct. But as long as there is no function call *between* > the variable definition and the assembly, the approach with the local > register variable works without any problems. It is even something GCC > itself has used in its library for years.
I'm glad it's workout out for GCC. But, the kernel is not GCC. I specifically asked for the ACRN code to be the way that it is today and your argument is not making me reconsider it in the slightest.
So, thanks for the patch, but I don't think we should apply it.
| |