lkml.org 
[lkml]   [2022]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf/core: Fix syzkaller reported issue "Internal error in read_pmevcntrn"
Hi Yang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/perf/core]
[also build test WARNING on linus/master v5.19 next-20220803]
[cannot apply to acme/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Yang-Jihong/perf-core-Fix-syzkaller-reported-issue-Internal-error-in-read_pmevcntrn/20220804-190347
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 326ecc15c61c349cd49d1700ff9e3e31c6fd1cd5
config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220805/202208050241.9fLxoaz4-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/9c758a8d3d13d1ac89f651850b79d91b23b41b02
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yang-Jihong/perf-core-Fix-syzkaller-reported-issue-Internal-error-in-read_pmevcntrn/20220804-190347
git checkout 9c758a8d3d13d1ac89f651850b79d91b23b41b02
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/events/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from include/linux/spinlock.h:54,
from include/linux/wait.h:9,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from kernel/events/core.c:11:
kernel/events/core.c: In function 'perf_output_read_group':
kernel/events/core.c:6942:27: error: 'flags' undeclared (first use in this function)
6942 | local_irq_restore(flags);
| ^~~~~
include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
include/linux/irqflags.h:228:22: note: in expansion of macro 'raw_irqs_disabled_flags'
228 | if (!raw_irqs_disabled_flags(flags)) \
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/events/core.c:6942:9: note: in expansion of macro 'local_irq_restore'
6942 | local_irq_restore(flags);
| ^~~~~~~~~~~~~~~~~
kernel/events/core.c:6942:27: note: each undeclared identifier is reported only once for each function it appears in
6942 | local_irq_restore(flags);
| ^~~~~
include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
include/linux/irqflags.h:228:22: note: in expansion of macro 'raw_irqs_disabled_flags'
228 | if (!raw_irqs_disabled_flags(flags)) \
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/events/core.c:6942:9: note: in expansion of macro 'local_irq_restore'
6942 | local_irq_restore(flags);
| ^~~~~~~~~~~~~~~~~
>> include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast
12 | (void)(&__dummy == &__dummy2); \
| ^~
include/linux/irqflags.h:193:17: note: in expansion of macro 'typecheck'
193 | typecheck(unsigned long, flags); \
| ^~~~~~~~~
include/linux/irqflags.h:228:22: note: in expansion of macro 'raw_irqs_disabled_flags'
228 | if (!raw_irqs_disabled_flags(flags)) \
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/events/core.c:6942:9: note: in expansion of macro 'local_irq_restore'
6942 | local_irq_restore(flags);
| ^~~~~~~~~~~~~~~~~
>> include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast
12 | (void)(&__dummy == &__dummy2); \
| ^~
include/linux/irqflags.h:182:17: note: in expansion of macro 'typecheck'
182 | typecheck(unsigned long, flags); \
| ^~~~~~~~~
include/linux/irqflags.h:230:17: note: in expansion of macro 'raw_local_irq_restore'
230 | raw_local_irq_restore(flags); \
| ^~~~~~~~~~~~~~~~~~~~~
kernel/events/core.c:6942:9: note: in expansion of macro 'local_irq_restore'
6942 | local_irq_restore(flags);
| ^~~~~~~~~~~~~~~~~


vim +12 include/linux/typecheck.h

e0deaff470900a4c Andrew Morton 2008-07-25 4
e0deaff470900a4c Andrew Morton 2008-07-25 5 /*
e0deaff470900a4c Andrew Morton 2008-07-25 6 * Check at compile time that something is of a particular type.
e0deaff470900a4c Andrew Morton 2008-07-25 7 * Always evaluates to 1 so you may use it easily in comparisons.
e0deaff470900a4c Andrew Morton 2008-07-25 8 */
e0deaff470900a4c Andrew Morton 2008-07-25 9 #define typecheck(type,x) \
e0deaff470900a4c Andrew Morton 2008-07-25 10 ({ type __dummy; \
e0deaff470900a4c Andrew Morton 2008-07-25 11 typeof(x) __dummy2; \
e0deaff470900a4c Andrew Morton 2008-07-25 @12 (void)(&__dummy == &__dummy2); \
e0deaff470900a4c Andrew Morton 2008-07-25 13 1; \
e0deaff470900a4c Andrew Morton 2008-07-25 14 })
e0deaff470900a4c Andrew Morton 2008-07-25 15

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-08-04 20:56    [W:0.085 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site