Messages in this thread | | | Date | Thu, 4 Aug 2022 09:51:52 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] can: mcp251x: Fix race condition on receive interrupt |
| |
On 04.08.2022 09:45:07, Sebastian Würl wrote: > On Thu, Aug 4, 2022 at 9:06 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote: > > > > Another optimization idea: Do we need to re-read the eflag1? "eflag" is > > for error handling only and you're optimizing the good path. > > I'd argue if a new message entered mailbox 1, this also potentially > changed the error state, so we need to read it.
Makes sense!
> Thanks a lot for your feedback! Will post v3 soon. > > Also I'm sorry for spam in anyones inbox, I didn't get my mailing > program to produce plain-text for the last mail.
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |