Messages in this thread | | | Date | Wed, 31 Aug 2022 17:36:26 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol |
| |
On Fri, Aug 26, 2022 at 11:35:04AM +0900, Steve Lee wrote:
> The Amp is already control in userspace before trigger calibrate function. > Remove unnecessary control in calibrate function.
I can't see anything which ensures that this is the case? Should there be a check which returns an error if the output is not enabled, or should the function check the current state and preserve it at the end? I can see that this would fix problems with it being disabled when callibrating. [unhandled content-type:application/pgp-signature] | |