lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v1 3/8] gpiolib: Warn on drivers still using static gpiobase allocation
    Date


    Le 30/08/2022 à 22:14, Andy Shevchenko a écrit :
    > On Mon, Aug 29, 2022 at 7:18 PM Christophe Leroy
    > <christophe.leroy@csgroup.eu> wrote:
    >>
    >> In the preparation of getting completely rid of static gpiobase
    >> allocation in the future, emit a warning in drivers still doing so.
    >
    > ...
    >
    >> + dev_warn(&gdev->dev, "Static allocation of GPIO base is "
    >> + "deprecated, use dynamic allocation.");
    >
    > First of all, do not split string literals. Second, you forgot '\n'.
    >

    Then I get a line longer than 100 chars, is that acceptable ?

    Since commit 5fd29d6ccbc9 ("printk: clean up handling of log-levels and
    newlines"), "\n" are just visual pollution, aren't they ?

    Christophe
    \
     
     \ /
      Last update: 2022-08-31 07:40    [W:2.709 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site