Messages in this thread | | | Date | Wed, 31 Aug 2022 15:04:24 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 12/19] hwmon: (mr75203) fix voltage equation for negative source input |
| |
On Tue, Aug 30, 2022 at 07:22:05PM +0000, Eliav Farber wrote: > According to Moortec Embedded Voltage Monitor (MEVM) series 3 data sheet, > the minimum input signal is -100mv and maximum input signal is +1000mv. > When n was small enough, such that PVT_N_CONST * n < PVT_R_CONST it > resulted in n overflowing to a very large number (since n is u32 type). > > This change fixes the problem by casting n to long and replacing shift > right with div operation.
Fixes tag?
...
> n &= SAMPLE_DATA_MSK; > +
Unrelated change.
-- With Best Regards, Andy Shevchenko
| |