Messages in this thread | | | Subject | Re: [PATCH v3 07/19] hwmon: (mr75203) enable polling for all VM channels | Date | Wed, 31 Aug 2022 14:55:28 +0300 | From | "Farber, Eliav" <> |
| |
On 8/31/2022 2:21 PM, Andy Shevchenko wrote: > On Tue, Aug 30, 2022 at 07:22:00PM +0000, Eliav Farber wrote: >> Configure ip-polling register to enable polling for all voltage monitor >> channels. >> This enables reading the voltage values for all inputs other than just >> input 0. > > ... > >> + val = GENMASK(pvt->c_num - 1, 0) | VM_CH_INIT | > > I believe in this case (BIT(pvt->c_num) - 1) is better, but not sure > if c_num can be 32. c_num can't be 32. I fix it in v4.
-- Thanks, Eliav
| |