lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 07/19] hwmon: (mr75203) enable polling for all VM channels
    On Tue, Aug 30, 2022 at 07:22:00PM +0000, Eliav Farber wrote:
    > Configure ip-polling register to enable polling for all voltage monitor
    > channels.
    > This enables reading the voltage values for all inputs other than just
    > input 0.

    ...

    > + val = GENMASK(pvt->c_num - 1, 0) | VM_CH_INIT |

    I believe in this case (BIT(pvt->c_num) - 1) is better, but not sure
    if c_num can be 32.

    > + IP_POLL << SDIF_ADDR_SFT |
    > + SDIF_WRN_W | SDIF_PROG;

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2022-08-31 13:23    [W:4.098 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site