Messages in this thread | | | Date | Wed, 31 Aug 2022 12:52:37 +0200 | From | Horatiu Vultur <> | Subject | Re: [PATCH v3 2/2] nvmem: lan9662-otp: add support. |
| |
The 08/31/2022 10:29, Krzysztof Kozlowski wrote:
Hi Krzysztof,
> > On 31/08/2022 09:42, Horatiu Vultur wrote: > > > +static const struct of_device_id lan9662_otp_match[] = { > > + { .compatible = "microchip,lan9662-otp", }, > > + { .compatible = "microchip,lan9668-otp", }, > > This is still wrong, does not match your bindings at all and still > duplicates entries without driver data. One entry - 9662.
I have look at some other drivers, where I can see they don't have any driver data. For example [1] and the bindings are here [2].
[1] https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/ti/cpsw_new.c#L1832 [2] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml#L23
Is this also wrong, or I still can't understand how the bindings are working?
If I put only one entry: --- static const struct of_device_id lan9662_otp_match[] = { { .compatible = "microchip,lan9662-otp", }, ---
Wouldn't be a problem that the binding mentions also lan9668?
> > Best regards, > Krzysztof
-- /Horatiu
| |