Messages in this thread | | | Date | Wed, 31 Aug 2022 17:30:13 +0800 | Subject | Re: [PATCH] sched/deadline: Add should_push_task_away helper | From | shangxiaojing <> |
| |
On 2022/8/31 17:23, Daniel Bristot de Oliveira wrote: > On 8/29/22 12:05, Shang XiaoJing wrote: >> +static inline bool should_push_task_away(struct task_struct *a, >> + struct task_struct *b) > static inline bool should_push_task_dl(struct task_struct *curr, struct task_struct *p) > > a and b are not good variable names, and add the _dl suffix (instead of away). ok, i like that :-). This will be done in patch v2. >> +{ >> + return unlikely(dl_task(a)) && >> + (a->nr_cpus_allowed < 2 || >> + !dl_entity_preempt(&b->dl, &a->dl)) && >> + b->nr_cpus_allowed > 1; >> +} >> + > -- Daniel
Thanks,
Shang XiaoJing
| |