lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 01/41] drm/tests: Order Kunit tests in Makefile
    Hi,

    On Tue, Aug 30, 2022 at 08:22:17AM -0400, Konstantin Ryabitsev wrote:
    > (Dropping most cc's, who probably don't care about this thread.)
    >
    > On Tue, Aug 30, 2022 at 10:30:27AM +0200, Maxime Ripard wrote:
    > > > I noticed this, too, and I think the reason is because these patches were
    > > > generated with "b4 send -o", but actually sent using git-send-email. It's not
    > > > a use-case I've considered (or tested) and the breakage is because when b4
    > > > generates patches with "-o", they are written with CRLF line endings, which is
    > > > not something git-send-email expects.
    > >
    > > You're right
    >
    > OK, the latest master should allow you to do that without causing CRLF errors
    > like this series.

    Thanks

    > > For some reason, b4 send doesn't work for my setup and I haven't had the
    > > time to look into why and let you know.
    >
    > Yeah, I see what the cause of it is:
    >
    > > Connecting to /home/max/.local/bin/msmtpq:0
    > > Failed to configure the smtp connection:
    > > [Errno -2] Name or service not known
    >
    > You have sendemail.smtpserver set to a path, which is supported by
    > git-sendemail, but not by b4 (yet). I'll see if I can put that in today.

    I saw that you fixed it in master, I'll give it a try, thanks!

    Another thing I noticed when using b4 send is that I'm not sure how to
    increment the version number of a series. With b4 send --dry-run it
    wasn't happening automatically, and I couldn't find anything related in
    the options (except for --force-revision but that wasn't permanent I
    think?)

    I ended up amending the commit json by hand to set the proper revision
    number, but I'm almost sure it isn't the right way :)

    Maxime

    \
     
     \ /
      Last update: 2022-08-31 09:30    [W:2.335 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site