lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name format
Date

> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: 2022年9月1日 10:10
> To: Joy Zou <joy.zou@nxp.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> dl-linux-imx <linux-imx@nxp.com>; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name
> format
>
> Caution: EXT Email
>
> Hi Joy.
>
> On Wed, Aug 31, 2022 at 11:02 PM Joy Zou <joy.zou@nxp.com> wrote:
> >
> > change the sdma node name format 'sdma' into 'dma-controller'.
>
> The changes looks good, but the commit log needs to be improved.
>
> Please explain the rationale for changing the name. Something like this:
>
> Node names should be generic, so change the node name from 'sdma' to
> 'dma-controller'.
>
Ok, I will modify the commit log in patch v5.
Thank you very much!
BR
Joy Zou
> Thanks
\
 
 \ /
  Last update: 2022-09-01 04:14    [W:0.541 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site