lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7] platform/chrome: cros_ec_lpc: Move host command to prepare/complete
    On Wed, Aug 31, 2022 at 12:00:55PM -0600, Tim Van Patten wrote:
    > Hi,
    >
    > Friendly ping on this patch.

    We don't top-post on Linux kernel mailing lists.

    > On Tue, Aug 23, 2022 at 9:59 AM Tim Van Patten <timvp@google.com> wrote:
    > >
    > > Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
    > > .prepare() and cros_ec_lpc_complete() during .complete(). This moves the
    > > host command that the AP sends and allows the EC to log entry/exit of
    > > AP's suspend/resume more accurately.
    > >
    > > Signed-off-by: Tim Van Patten <timvp@google.com>
    > > ---
    > >
    > > Changes in v7:
    > > - Rename "host event" to "host command" in title/description.
    > >
    > > Changes in v6:
    > > - Fully restore fixes from v3.
    > >
    > > Changes in v5:
    > > - Restore fixes from v3.
    > >
    > > Changes in v4:
    > > - Update title and description.
    > >
    > > Changes in v3:
    > > - Update cros_ec_lpc_suspend() to cros_ec_lpc_prepare()
    > > - Update cros_ec_lpc_resume() to cros_ec_lpc_complete()
    > >
    > > Changes in v2:
    > > - Include cros_ec_resume() return value in dev_info() output.
    > > - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP.

    I don't buy-in the ideas from the discussion in v3[1]. Thus, I would defer
    to other reviewers/maintainers on the list to seek their suggestions.

    [1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid/

    \
     
     \ /
      Last update: 2022-09-01 03:53    [W:5.496 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site