Messages in this thread | | | From | Daniel Latypov <> | Date | Wed, 31 Aug 2022 12:01:16 -0700 | Subject | Re: [PATCH] overflow: Split up kunit tests for smaller stack frames |
| |
On Wed, Aug 31, 2022 at 11:11 AM Kees Cook <keescook@chromium.org> wrote: > > Under some pathological 32-bit configs, the shift overflow KUnit tests > create huge stack frames. Split up the function to avoid this, > separating by rough shift overflow cases. > > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Cc: Daniel Latypov <dlatypov@google.com> > Cc: Vitor Massaru Iha <vitor@massaru.org> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202208301850.iuv9VwA8-lkp@intel.com > Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Daniel Latypov <dlatypov@google.com>
It's sad that we're forced to do this to eliminate such warnings, but I like this organization a bit better, actually.
I wasn't able to reproduce the stack size warnings in the past, so I haven't tried to do so here and can't give Tested-by/Reviewed-by. But I did run the tests and they all still worked for me.
| |