lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH nolibc 06/18] selftests/nolibc: implement a few tests for various syscalls
    Date
    From: Willy Tarreau <w@1wt.eu>

    This adds 63 tests covering about 34 syscalls. Both successes and
    failures are tested. Two tests fail when run as unprivileged user
    (link_dir which returns EACCESS instead of EPERM, and chroot which
    returns EPERM). One test (execve("/")) expects to fail on EACCESS,
    but needs to have valid arguments otherwise the kernel will log a
    message. And a few tests require /proc to be mounted.

    The code is not pretty since all tests are one-liners, sometimes
    resulting in long lines, especially when using compount statements to
    preset a line, but it's convenient and doesn't obfuscate the code,
    which is important to understand what failed.

    Signed-off-by: Willy Tarreau <w@1wt.eu>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    ---
    tools/testing/selftests/nolibc/nolibc-test.c | 110 +++++++++++++++++++
    1 file changed, 110 insertions(+)

    diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
    index 49177ea9943cc..dc87832912ce4 100644
    --- a/tools/testing/selftests/nolibc/nolibc-test.c
    +++ b/tools/testing/selftests/nolibc/nolibc-test.c
    @@ -388,9 +388,119 @@ static int expect_strne(const char *expr, int llen, const char *cmp)
    case __LINE__: llen += printf("%d %s", test, #name);


    +/* used by some syscall tests below */
    +int test_getdents64(const char *dir)
    +{
    + char buffer[4096];
    + int fd, ret;
    + int err;
    +
    + ret = fd = open(dir, O_RDONLY | O_DIRECTORY, 0);
    + if (ret < 0)
    + return ret;
    +
    + ret = getdents64(fd, (void *)buffer, sizeof(buffer));
    + err = errno;
    + close(fd);
    +
    + errno = err;
    + return ret;
    +}
    +
    +/* Run syscall tests between IDs <min> and <max>.
    + * Return 0 on success, non-zero on failure.
    + */
    +int run_syscall(int min, int max)
    +{
    + struct stat stat_buf;
    + int test;
    + int tmp;
    + int ret = 0;
    + void *p1, *p2;
    +
    + for (test = min; test >= 0 && test <= max; test++) {
    + int llen = 0; // line length
    +
    + /* avoid leaving empty lines below, this will insert holes into
    + * test numbers.
    + */
    + switch (test + __LINE__ + 1) {
    + CASE_TEST(getpid); EXPECT_SYSNE(1, getpid(), -1); break;
    + CASE_TEST(getppid); EXPECT_SYSNE(1, getppid(), -1); break;
    + CASE_TEST(gettid); EXPECT_SYSNE(1, gettid(), -1); break;
    + CASE_TEST(getpgid_self); EXPECT_SYSNE(1, getpgid(0), -1); break;
    + CASE_TEST(getpgid_bad); EXPECT_SYSER(1, getpgid(-1), -1, ESRCH); break;
    + CASE_TEST(kill_0); EXPECT_SYSZR(1, kill(getpid(), 0)); break;
    + CASE_TEST(kill_CONT); EXPECT_SYSZR(1, kill(getpid(), 0)); break;
    + CASE_TEST(kill_BADPID); EXPECT_SYSER(1, kill(INT_MAX, 0), -1, ESRCH); break;
    + CASE_TEST(sbrk); if ((p1 = p2 = sbrk(4096)) != (void *)-1) p2 = sbrk(-4096); EXPECT_SYSZR(1, (p2 == (void *)-1) || p2 == p1); break;
    + CASE_TEST(brk); EXPECT_SYSZR(1, brk(sbrk(0))); break;
    + CASE_TEST(chdir_root); EXPECT_SYSZR(1, chdir("/")); break;
    + CASE_TEST(chdir_dot); EXPECT_SYSZR(1, chdir(".")); break;
    + CASE_TEST(chdir_blah); EXPECT_SYSER(1, chdir("/blah"), -1, ENOENT); break;
    + CASE_TEST(chmod_net); EXPECT_SYSZR(1, chmod("/proc/self/net", 0555)); break;
    + CASE_TEST(chmod_self); EXPECT_SYSER(1, chmod("/proc/self", 0555), -1, EPERM); break;
    + CASE_TEST(chown_self); EXPECT_SYSER(1, chown("/proc/self", 0, 0), -1, EPERM); break;
    + CASE_TEST(chroot_root); EXPECT_SYSZR(1, chroot("/")); break;
    + CASE_TEST(chroot_blah); EXPECT_SYSER(1, chroot("/proc/self/blah"), -1, ENOENT); break;
    + CASE_TEST(chroot_exe); EXPECT_SYSER(1, chroot("/proc/self/exe"), -1, ENOTDIR); break;
    + CASE_TEST(close_m1); EXPECT_SYSER(1, close(-1), -1, EBADF); break;
    + CASE_TEST(close_dup); EXPECT_SYSZR(1, close(dup(0))); break;
    + CASE_TEST(dup_0); tmp = dup(0); EXPECT_SYSNE(1, tmp, -1); close(tmp); break;
    + CASE_TEST(dup_m1); tmp = dup(-1); EXPECT_SYSER(1, tmp, -1, EBADF); if (tmp != -1) close(tmp); break;
    + CASE_TEST(dup2_0); tmp = dup2(0, 100); EXPECT_SYSNE(1, tmp, -1); close(tmp); break;
    + CASE_TEST(dup2_m1); tmp = dup2(-1, 100); EXPECT_SYSER(1, tmp, -1, EBADF); if (tmp != -1) close(tmp); break;
    + CASE_TEST(dup3_0); tmp = dup3(0, 100, 0); EXPECT_SYSNE(1, tmp, -1); close(tmp); break;
    + CASE_TEST(dup3_m1); tmp = dup3(-1, 100, 0); EXPECT_SYSER(1, tmp, -1, EBADF); if (tmp != -1) close(tmp); break;
    + CASE_TEST(execve_root); EXPECT_SYSER(1, execve("/", (char*[]){ [0] = "/", [1] = NULL }, NULL), -1, EACCES); break;
    + CASE_TEST(getdents64_root); EXPECT_SYSNE(1, test_getdents64("/"), -1); break;
    + CASE_TEST(getdents64_null); EXPECT_SYSER(1, test_getdents64("/dev/null"), -1, ENOTDIR); break;
    + CASE_TEST(gettimeofday_null); EXPECT_SYSZR(1, gettimeofday(NULL, NULL)); break;
    + CASE_TEST(gettimeofday_bad1); EXPECT_SYSER(1, gettimeofday((void *)1, NULL), -1, EFAULT); break;
    + CASE_TEST(gettimeofday_bad2); EXPECT_SYSER(1, gettimeofday(NULL, (void *)1), -1, EFAULT); break;
    + CASE_TEST(gettimeofday_bad2); EXPECT_SYSER(1, gettimeofday(NULL, (void *)1), -1, EFAULT); break;
    + CASE_TEST(ioctl_tiocinq); EXPECT_SYSZR(1, ioctl(0, TIOCINQ, &tmp)); break;
    + CASE_TEST(ioctl_tiocinq); EXPECT_SYSZR(1, ioctl(0, TIOCINQ, &tmp)); break;
    + CASE_TEST(link_root1); EXPECT_SYSER(1, link("/", "/"), -1, EEXIST); break;
    + CASE_TEST(link_blah); EXPECT_SYSER(1, link("/proc/self/blah", "/blah"), -1, ENOENT); break;
    + CASE_TEST(link_dir); EXPECT_SYSER(1, link("/", "/blah"), -1, EPERM); break;
    + CASE_TEST(link_cross); EXPECT_SYSER(1, link("/proc/self/net", "/blah"), -1, EXDEV); break;
    + CASE_TEST(lseek_m1); EXPECT_SYSER(1, lseek(-1, 0, SEEK_SET), -1, EBADF); break;
    + CASE_TEST(lseek_0); EXPECT_SYSER(1, lseek(0, 0, SEEK_SET), -1, ESPIPE); break;
    + CASE_TEST(mkdir_root); EXPECT_SYSER(1, mkdir("/", 0755), -1, EEXIST); break;
    + CASE_TEST(open_tty); EXPECT_SYSNE(1, tmp = open("/dev/null", 0), -1); if (tmp != -1) close(tmp); break;
    + CASE_TEST(open_blah); EXPECT_SYSER(1, tmp = open("/proc/self/blah", 0), -1, ENOENT); if (tmp != -1) close(tmp); break;
    + CASE_TEST(poll_null); EXPECT_SYSZR(1, poll(NULL, 0, 0)); break;
    + CASE_TEST(poll_stdout); EXPECT_SYSNE(1, ({ struct pollfd fds = { 1, POLLOUT, 0}; poll(&fds, 1, 0); }), -1); break;
    + CASE_TEST(poll_fault); EXPECT_SYSER(1, poll((void *)1, 1, 0), -1, EFAULT); break;
    + CASE_TEST(read_badf); EXPECT_SYSER(1, read(-1, &tmp, 1), -1, EBADF); break;
    + CASE_TEST(sched_yield); EXPECT_SYSZR(1, sched_yield()); break;
    + CASE_TEST(select_null); EXPECT_SYSZR(1, ({ struct timeval tv = { 0 }; select(0, NULL, NULL, NULL, &tv); })); break;
    + CASE_TEST(select_stdout); EXPECT_SYSNE(1, ({ fd_set fds; FD_ZERO(&fds); FD_SET(1, &fds); select(2, NULL, &fds, NULL, NULL); }), -1); break;
    + CASE_TEST(select_fault); EXPECT_SYSER(1, select(1, (void *)1, NULL, NULL, 0), -1, EFAULT); break;
    + CASE_TEST(stat_blah); EXPECT_SYSER(1, stat("/proc/self/blah", &stat_buf), -1, ENOENT); break;
    + CASE_TEST(stat_fault); EXPECT_SYSER(1, stat(NULL, &stat_buf), -1, EFAULT); break;
    + CASE_TEST(symlink_root); EXPECT_SYSER(1, symlink("/", "/"), -1, EEXIST); break;
    + CASE_TEST(unlink_root); EXPECT_SYSER(1, unlink("/"), -1, EISDIR); break;
    + CASE_TEST(unlink_blah); EXPECT_SYSER(1, unlink("/proc/self/blah"), -1, ENOENT); break;
    + CASE_TEST(wait_child); EXPECT_SYSER(1, wait(&tmp), -1, ECHILD); break;
    + CASE_TEST(waitpid_min); EXPECT_SYSER(1, waitpid(INT_MIN, &tmp, WNOHANG), -1, ESRCH); break;
    + CASE_TEST(waitpid_child); EXPECT_SYSER(1, waitpid(getpid(), &tmp, WNOHANG), -1, ECHILD); break;
    + CASE_TEST(write_badf); EXPECT_SYSER(1, write(-1, &tmp, 1), -1, EBADF); break;
    + CASE_TEST(write_zero); EXPECT_SYSZR(1, write(1, &tmp, 0)); break;
    + case __LINE__:
    + return ret; /* must be last */
    + /* note: do not set any defaults so as to permit holes above */
    + }
    + }
    + return ret;
    +}
    +
    +
    /* This is the definition of known test names, with their functions */
    static struct test test_names[] = {
    /* add new tests here */
    + { .name = "syscall", .func = run_syscall },
    { 0 }
    };

    --
    2.31.1.189.g2e36527f23
    \
     
     \ /
      Last update: 2022-08-31 20:28    [W:2.891 / U:0.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site