Messages in this thread | | | From | Prashant Malani <> | Date | Wed, 31 Aug 2022 11:13:20 -0700 | Subject | Re: [PATCH] platform/chrome: cros_ec_typec: Register partner PDOs |
| |
Thanks for the review, Heikki.
On Wed, Aug 31, 2022 at 1:45 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Tue, Aug 30, 2022 at 08:20:18PM +0000, Prashant Malani wrote: > > The ChromeOS EC exports partner source/sink cap PDOs (Power Data > > Objects) to the application processor (AP). Use this information > > to register USB PD (Power Delivery) capabilities with the > > USB Type-C Power Delivery device class. > > > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > Signed-off-by: Prashant Malani <pmalani@chromium.org> > > This looks good to me. One nitpick below. With that fixed, FWIW: > > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > Will you later register also the port PDOs? Yes, that is the plan.
> > if (resp.events & PD_STATUS_EVENT_SOP_PRIME_DISC_DONE && > > @@ -1006,6 +1061,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num > > "Failed SOP Disc event clear, port: %d\n", port_num); > > } > > } > > + > > } > > I'm guessing that extra newline was just a typo.
Yeah ,I missed it during self-review :( I'll fix it up while applying the patch if there is no other comment. Otherwise I'll fix it in v2 (if there is one).
| |