Messages in this thread | | | Date | Wed, 31 Aug 2022 10:53:50 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 1/2] testing/selftests: Add tests for the is_signed_type() macro |
| |
On Mon, Aug 29, 2022 at 08:30:54PM -0700, Bart Van Assche wrote: > On 8/29/22 19:33, Isabella Basso wrote: > > > +#include <kunit/test.h> > > > +#include <linux/overflow.h> > > > > Nit: I don’t know if that makes a huge difference but you might include > > `<linux/compiler.h>` directly to make the final object smaller. Of course, that > > would ideally be a change happening in 2/2 but that was already merged :). > > Right, that could have been done in patch 2/2 but I think this can also be > done as a follow-up patch. I'm not sure what Kees prefers?
A follow-up would be easier for me. And perhaps could include Rasmus's suggestions too?
-- Kees Cook
| |