Messages in this thread | | | From | Benjamin Tissoires <> | Date | Tue, 30 Aug 2022 15:30:26 +0200 | Subject | Re: [PATCH bpf-next v7 24/24] Documentation: add HID-BPF docs |
| |
On Thu, Aug 25, 2022 at 4:53 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote: > > On Thu, Jul 21, 2022 at 05:36:25PM +0200, Benjamin Tissoires wrote: > > +When (and why) to use HID-BPF > > +============================= > > + > > +We can enumerate several use cases for when using HID-BPF is better than > > +using a standard kernel driver fix: > > + > > Better say "There are several use cases when using HID-BPF is better > than standard kernel driver fix:"
OK, included locally, and will send it in v10.
> > > +When a BPF program needs to emit input events, it needs to talk HID, and rely > > +on the HID kernel processing to translate the HID data into input events. > > + > > talk to HID?
Replaced with "it needs to talk with the HID protocol".
> > Otherwise the documentation LGTM (no new warnings caused by the doc).
Great, thanks a lot for the review :)
Cheers, Benjamin
> > -- > An old man doll... just what I always wanted! - Clara
| |