lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] dt-bindings: PCI: qcom-ep: Define clocks per platform
On Sun, Aug 28, 2022 at 06:20:21PM +0300, Krzysztof Kozlowski wrote:
> On 26/08/2022 21:19, Manivannan Sadhasivam wrote:
> > In preparation of adding the bindings for future SoCs, let's define the
> > clocks per platform.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 46 +++++++++++--------
> > 1 file changed, 27 insertions(+), 19 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > index b728ede3f09f..83a2cfc63bc1 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > @@ -9,9 +9,6 @@ title: Qualcomm PCIe Endpoint Controller binding
> > maintainers:
> > - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > -allOf:
> > - - $ref: "pci-ep.yaml#"
> > -
> > properties:
> > compatible:
> > const: qcom,sdx55-pcie-ep
> > @@ -35,24 +32,12 @@ properties:
> > - const: mmio
> >
> > clocks:
> > - items:
> > - - description: PCIe Auxiliary clock
> > - - description: PCIe CFG AHB clock
> > - - description: PCIe Master AXI clock
> > - - description: PCIe Slave AXI clock
> > - - description: PCIe Slave Q2A AXI clock
> > - - description: PCIe Sleep clock
> > - - description: PCIe Reference clock
> > + minItems: 7
> > + maxItems: 7
> >
> > clock-names:
> > - items:
> > - - const: aux
> > - - const: cfg
> > - - const: bus_master
> > - - const: bus_slave
> > - - const: slave_q2a
> > - - const: sleep
> > - - const: ref
> > + minItems: 7
> > + maxItems: 7
> >
> > qcom,perst-regs:
> > description: Reference to a syscon representing TCSR followed by the two
> > @@ -112,6 +97,29 @@ required:
> > - reset-names
> > - power-domains
> >
> > +allOf:
> > + - $ref: "pci-ep.yaml#"
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,sdx55-pcie-ep
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 7
> > + maxItems: 7
>
> One more thing - the previous way of describing items is more readable
> instead of names followed by a comment, so I propose to keep it. This
> applies also to patch 10.
>

Okay.

Thanks,
Mani

> Best regards,
> Krzysztof

--
மணிவண்ணன் சதாசிவம்

\
 
 \ /
  Last update: 2022-08-30 13:57    [W:0.088 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site