Messages in this thread | | | Date | Tue, 30 Aug 2022 13:35:04 +0200 | Subject | Re: [PATCH v2 linux-next] wifi: brcmfmac: remove redundant err variable | From | Arend Van Spriel <> |
| |
On 8/30/2022 12:50 PM, cgel.zte@gmail.com wrote: > From: Jinpeng Cui <cui.jinpeng2@zte.com.cn> > > Return value from brcmf_fil_iovar_data_set() and > brcmf_config_ap_mgmt_ie() directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn> > --- > .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > index 7c72ea26a7d7..8a8c5a3bb2fb 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c [...]
> @@ -3997,10 +3996,8 @@ brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp) > for (i = 0; i < npmk; i++) > brcmf_dbg(CONN, "PMK[%d]: %pM\n", i, &pmk_list->pmk[i].bssid); > > - err = brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list, > + return brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list, > sizeof(*pmk_list));
You should align the next line on the column after the opening brace. Using the checkpatch script should report this.
> - > - return err; > } > > static s32
| |