Messages in this thread | | | Date | Tue, 30 Aug 2022 12:53:39 +0300 | Subject | Re: [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62A | From | Krzysztof Kozlowski <> |
| |
On 29/08/2022 11:21, Vignesh Raghavendra wrote: > Add pinctrl macros for AM62AX SoCs. These macro definitions are similar > to that of previous platforms, but adding new definitions to avoid any > naming confusions in the SoC dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> > --- > include/dt-bindings/pinctrl/k3.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h > index a5204ab91d3e..97cd2e39efa4 100644 > --- a/include/dt-bindings/pinctrl/k3.h > +++ b/include/dt-bindings/pinctrl/k3.h > @@ -44,4 +44,6 @@ > #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > +#define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > +#define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode))
Alphabetical order, so maybe before AM642?
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |