lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/4] bindings: fpga: Add binding doc for the zynqmp afi config driver
Date
Hi Krzysztof,

Please find my response inline.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, August 24, 2022 6:29 PM
> To: Manne, Nava kishore <nava.kishore.manne@amd.com>; git (AMD-Xilinx)
> <git@amd.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> michal.simek@xilinx.com; mdf@kernel.org; hao.wu@intel.com;
> yilun.xu@intel.com; trix@redhat.com; p.zabel@pengutronix.de;
> gregkh@linuxfoundation.org; ronak.jain@xilinx.com; rajan.vaja@xilinx.com;
> abhyuday.godhasara@xilinx.com; piyush.mehta@xilinx.com;
> lakshmi.sai.krishna.potthuri@xilinx.com; harsha.harsha@xilinx.com;
> linus.walleij@linaro.org; nava.manne@xilinx.com;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; linux-fpga@vger.kernel.org
> Subject: Re: [PATCH 2/4] bindings: fpga: Add binding doc for the zynqmp afi
> config driver
>
> On 24/08/2022 06:55, Nava kishore Manne wrote:
> > Xilinx Zynq US+ MPSoC platform connect the PS to the programmable
> > logic(PL) through the AXI port. This AXI port helps to establish
>
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>

Will fix in v2.

> > the data path between the PS and PL. In-order to establish the proper
> > communication data path between PS and PL the AXI port data path
> > should be configured with the proper Bus-width values.
> >
> > This patch adds the binding document for the zynqmp afi config driver
> > to handle the AXI port bus-width configurations and PS-PL resets.
>
> Do not use "This commit/patch".
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/sub
> mitting-patches.rst#L95
>

Will fix in v2.

> >
> > Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> > ---
> > .../bindings/fpga/xlnx,zynqmp-afi-fpga.yaml | 100 ++++++++++++++++++
> > 1 file changed, 100 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/fpga/xlnx,zynqmp-afi-fpga.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-afi-fpga.yaml
> > b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-afi-fpga.yaml
> > new file mode 100644
> > index 000000000000..faae4951e991
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-afi-
> fpga.yaml
> > @@ -0,0 +1,100 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/fpga/xlnx,zynqmp-afi-fpga.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Xilinx ZynqMP AFI interface Manager.
> > +
> > +maintainers:
> > + - Nava kishore Manne <nava.kishore.manne@amd.com>
> > +
> > +description: The Zynq UltraScale+ MPSoC Processing System core
> > +provides access
> > + from PL masters to PS internal peripherals, and memory through AXI
> > +FIFO
> > + interface(AFI)
> > +
> > +properties:
> > + compatible:
> > + items:
>
> No items, you have only one item.
>

Will fix in v2.

> > + - enum:
> > + - xlnx,zynqmp-afi-fpga
> > +
> > + resets:
> > + description:
> > + A list of phandles for resets listed in reset-names.
>
> You need maxItems:4
>

Will fix in v2.

> > +
> > + reset-names:
> > + items:
> > + - const: pl0-rst
> > + - const: pl1-rst
> > + - const: pl2-rst
> > + - const: pl3-rst
> > +
> > +patternProperties:
> > + "^xlnx,afifm[0-6]-rd-bus-width$":
> > + description: bus width used to configure the afifm-rd interface.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [ 32, 64, 128 ]
> > +
> > + "^xlnx,afifm[0-6]-wr-bus-width$":
> > + description: bus width used to configure the afifm-wr interface.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [ 32, 64, 128 ]
> > +
> > + "^xlnx,afifs-ss[0-2]-bus-width$":
> > + description: bus width used to configure the afifs interface.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [ 32, 64, 128 ]
> > +
> > +required:
> > + - compatible
> > + - xlnx,afifm0-rd-bus-width
> > + - xlnx,afifm1-rd-bus-width
> > + - xlnx,afifm2-rd-bus-width
> > + - xlnx,afifm3-rd-bus-width
> > + - xlnx,afifm4-rd-bus-width
> > + - xlnx,afifm5-rd-bus-width
> > + - xlnx,afifm6-rd-bus-width
> > + - xlnx,afifm0-wr-bus-width
> > + - xlnx,afifm1-wr-bus-width
> > + - xlnx,afifm2-wr-bus-width
> > + - xlnx,afifm3-wr-bus-width
> > + - xlnx,afifm4-wr-bus-width
> > + - xlnx,afifm5-wr-bus-width
> > + - xlnx,afifm6-wr-bus-width
> > + - xlnx,afifs-ss0-bus-width
> > + - xlnx,afifs-ss1-bus-width
> > + - xlnx,afifs-ss2-bus-width
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/reset/xlnx-zynqmp-resets.h>
> > + zynqmp-afi {
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-
> devicetree-basics.html#generic-names-recommendation
>

Will fix in v2.

Regards,
Navakishore.
\
 
 \ /
  Last update: 2022-08-30 07:32    [W:0.082 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site