Messages in this thread | | | Date | Tue, 30 Aug 2022 10:59:22 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] cpufreq: bmips-cpufreq: Use module_init and add module_exit |
| |
On 26-08-22, 10:18, Zhang Jianhua wrote: > - Use module_init instead of device_initcall. > - Add a function for module_exit to unregister driver. > > Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com> > --- > drivers/cpufreq/bmips-cpufreq.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/bmips-cpufreq.c b/drivers/cpufreq/bmips-cpufreq.c > index f7c23fa468f0..21c0417c95e1 100644 > --- a/drivers/cpufreq/bmips-cpufreq.c > +++ b/drivers/cpufreq/bmips-cpufreq.c > @@ -156,7 +156,7 @@ static struct cpufreq_driver bmips_cpufreq_driver = { > .name = BMIPS_CPUFREQ_PREFIX, > }; > > -static int __init bmips_cpufreq_probe(void) > +static int __init bmips_cpufreq_driver_init(void) > { > struct cpufreq_compat *cc; > struct device_node *np; > @@ -176,7 +176,13 @@ static int __init bmips_cpufreq_probe(void) > > return cpufreq_register_driver(&bmips_cpufreq_driver); > } > -device_initcall(bmips_cpufreq_probe); > +module_init(bmips_cpufreq_driver_init); > + > +static void __exit bmips_cpufreq_driver_exit(void) > +{ > + cpufreq_unregister_driver(&bmips_cpufreq_driver); > +} > +module_exit(bmips_cpufreq_driver_exit)
Semicolon ? Did you even compile this ? :)
> > MODULE_AUTHOR("Markus Mayer <mmayer@broadcom.com>"); > MODULE_DESCRIPTION("CPUfreq driver for Broadcom BMIPS SoCs"); > -- > 2.31.0
-- viresh
| |